Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Ensure the QA check does not influence the report #22150

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Fix] Ensure the QA check does not influence the report #22150

merged 1 commit into from
Jan 31, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jan 31, 2023 •
edited
Loading

What

Remove the QA-engine input from the report script to ensure passing builds

related to #22127

How

Disabled in the shell script for now.

Will move to a github action default value in the future.

Chose this way as the script input is testable on my machine, but a complex github action is not.

Post merge

  • Run all integration tests
  • Build slack report report

@bnchrch bnchrch requested a review from erohmensing January 31, 2023 16:35
@bnchrch bnchrch temporarily deployed to more-secrets January 31, 2023 16:36 — with GitHub Actions Inactive
@bnchrch bnchrch temporarily deployed to more-secrets January 31, 2023 16:37 — with GitHub Actions Inactive
@bnchrch bnchrch enabled auto-merge (squash) January 31, 2023 16:37
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51% ❌

@bnchrch bnchrch requested a review from pedroslopez January 31, 2023 17:10
@bnchrch bnchrch disabled auto-merge January 31, 2023 17:27
@bnchrch bnchrch self-assigned this Jan 31, 2023
@bnchrch
Copy link
Contributor Author

bnchrch commented Jan 31, 2023

/test connector=connectors/source-pokeapi

@bnchrch
Copy link
Contributor Author

bnchrch commented Jan 31, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4057099518
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/4057099518
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1690    341    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestSpec.test_config_match_spec: The spec is currently invalid: it has additionalProperties set to false
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not support incremental syncs.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
======================== 12 passed, 3 skipped in 9.31s =========================

@bnchrch bnchrch enabled auto-merge (squash) January 31, 2023 18:40
@bnchrch bnchrch merged commit c8257e4 into master Jan 31, 2023
@bnchrch bnchrch deleted the bechurch/feat-qa-engine-remove-script-input-22127 branch January 31, 2023 18:46
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

@erohmensing erohmensing Awaiting requested review from erohmensing

Assignees

@bnchrch bnchrch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnchrch @pedroslopez